Bug 1727076 - Have PingUploadWorker sleep in case it gets a Wait task #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
force-pushed
the
1727076-wait-on-timer
branch
from
a6c26f2
to
aeef6c9
Compare
brizental
force-pushed
the
1727076-wait-on-timer
branch
from
aeef6c9
to
201d298
Compare
brizental
force-pushed
the
1727076-wait-on-timer
branch
from
201d298
to
a8e515d
Compare
chutten
approved these changes
Dec 7, 2021
This was causing a bug in case the workInternal function was faster than actually setting the currentJob property e.g. when there was only a Done task to process. In that case the currentJob would never be cleared and the worker would never be restarted.
brizental
force-pushed
the
1727076-wait-on-timer
branch
from
b8dc28a
to
b48628a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need oneDocumentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work