Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1662584 - Submitting a ping with upload disabled no longer errors #1201

Merged
merged 1 commit into from Sep 8, 2020
Merged

Bug 1662584 - Submitting a ping with upload disabled no longer errors #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion glean-core/android/src/main/java/mozilla/telemetry/glean/Glean.kt
View file
Open in desktop
Expand Up @@ -635,7 +635,7 @@ open class GleanInternalAPI internal constructor () {
}

if (!internalGetUploadEnabled()) {
Log.e(LOG_TAG, "Glean disabled: not submitting any pings.")
Log.i(LOG_TAG, "Glean disabled: not submitting any pings.")
return
}

Expand Down
2 changes: 1 addition & 1 deletion glean-core/csharp/Glean/Glean.cs
View file
Open in desktop
Expand Up @@ -591,7 +591,7 @@ internal void SubmitPingByNameSync(string name, string reason = null)

if (!GetUploadEnabled())
{
Log.Error("Glean disabled: not submitting any pings.");
Log.Information("Glean disabled: not submitting any pings.");
return;
}

Expand Down
2 changes: 1 addition & 1 deletion glean-core/ios/Glean/Glean.swift
View file
Open in desktop
Expand Up @@ -445,7 +445,7 @@ public class Glean {
}

if !self.internalGetUploadEnabled() {
self.logger.error("Glean disabled: not submitting any pings")
self.logger.info("Glean disabled: not submitting any pings")
return
}

Expand Down
2 changes: 1 addition & 1 deletion glean-core/python/glean/glean.py
View file
Open in desktop
Expand Up @@ -548,7 +548,7 @@ def _submit_ping_by_name(cls, ping_name: str, reason: Optional[str] = None) -> N
return

if not cls._get_upload_enabled():
log.error("Glean disabled: not submitting any pings.")
log.info("Glean disabled: not submitting any pings.")
return

sent_ping = _ffi.lib.glean_submit_ping_by_name(
Expand Down
2 changes: 1 addition & 1 deletion glean-core/src/lib.rs
View file
Open in desktop
Expand Up @@ -584,7 +584,7 @@ impl Glean {
/// If collecting or writing the ping to disk failed.
pub fn submit_ping(&self, ping: &PingType, reason: Option<&str>) -> Result<bool> {
if !self.is_upload_enabled() {
log::error!("Glean disabled: not submitting any pings.");
log::info!("Glean disabled: not submitting any pings.");
return Ok(false);
}

Expand Down