Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1686726 - Fix lock order inversion in RLB Timing Distribution #1431

Merged
merged 1 commit into from Jan 14, 2021
Merged

bug 1686726 - Fix lock order inversion in RLB Timing Distribution #1431

merged 1 commit into from Jan 14, 2021

Conversation

chutten
Copy link
Contributor

@chutten chutten commented Jan 14, 2021

No description provided.

Dexterp37
Dexterp37 approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc. Before merging, would you kindly do two things:

  1. make sure this fixes the problem detected by TSAN
  2. make sure the suggested change doesn't break linting :)

glean-core/rlb/src/private/timing_distribution.rs Outdated Show resolved Hide resolved
@chutten chutten force-pushed the bug1686726-lockInversionTimingDist branch from 3d6ef16 to a410ffc Compare January 14, 2021 20:51
@chutten
Copy link
Contributor Author

chutten commented Jan 14, 2021

Tested that it fixed the TSan-discovered fault by using https://firefox-source-docs.mozilla.org/build/buildsystem/rust.html#patching-third-party-crates and https://firefox-source-docs.mozilla.org/tools/sanitizer/tsan.html. With this fix, no inversion. Without this fix, inversion.

@chutten chutten merged commit 98520aa into mozilla:main Jan 14, 2021
@chutten chutten deleted the bug1686726-lockInversionTimingDist branch January 14, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chutten @Dexterp37