Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift: use the client activity API to handle foreground/background events #1465

Merged
merged 5 commits into from Jan 28, 2021
Merged

Swift: use the client activity API to handle foreground/background events #1465

merged 5 commits into from Jan 28, 2021

Conversation

badboy
Copy link
Member

@badboy badboy commented Jan 28, 2021

No description provided.

Dexterp37
Dexterp37 requested changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are tests failing?

I can't seem to find where in the code the events ping gets generated, may be due to that? (if we record > 500 events)

Moreover, this is lacking a changelog entry :)

@badboy
Copy link
Member Author

badboy commented Jan 28, 2021

Why are tests failing?

I have to find out.

I can't seem to find where in the code the events ping gets generated, may be due to that? (if we record > 500 events)

That's internal and shouldn't change 🤔

Moreover, this is lacking a changelog entry :)

True that, will add it

@badboy badboy requested a review from Dexterp37 January 28, 2021 14:19
travis79
travis79 approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of annoying to have to ignore all the inital "active" pings for tests, but beats intermittent test failures. LGTM!

@badboy badboy merged commit 290624b into main Jan 28, 2021
@badboy badboy deleted the activity_api-swift branch January 28, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

@travis79 travis79 travis79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@badboy @Dexterp37 @travis79