Bug 1738878 - Glean parser with tags #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings tags support
badboy
force-pushed
the
glean-parser-with-tags
branch
from
cbf1bd5
to
31ac451
Compare
Also adds tags to the sample app to test it out.
badboy
force-pushed
the
glean-parser-with-tags
branch
from
31ac451
to
3ed4206
Compare
|
Test is green now (but running with SSH enabled, I'll cancel that, then still merge this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires mozilla/glean_parser#409 and a followup release.
We should probably document that.
cc @wlach