bug 1779003 - Consistently note event extra value length limit of 100B [doc only] #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis79
approved these changes
Jul 20, 2022
| * The values in the `extras` object have a maximum length of 100 bytes, when serialized and encoded as UTF-8. | ||
|
|
||
| * The values in the `extras` object have a maximum length of 100 bytes when serialized and encoded as UTF-8. | ||
| Longer values are truncated, and an error is recorded. |
There was a problem hiding this comment.
Suggested change
| Longer values are truncated, and an error is recorded. | |
| Longer values are truncated, and an `invalid_overflow` error is recorded. |
There was a problem hiding this comment.
@travis79 Ah, but that isn't true in builds prior to Glean 31.5.0. Should I go full specific or full vague?
There was a problem hiding this comment.
Ahh, that's a good point. Disregard that comment then and full vague might be my preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.