New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1790501 - Add count to DistributionData payload #2196
Bug 1790501 - Add count to DistributionData payload #2196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing some weirdness that I don't understand with i64
& u64
in the Kotlin tests. If anyone more knowledgeable about Rust or Kotlin has any ideas, it would be much appreciated!
...re/android/src/test/java/mozilla/telemetry/glean/private/TimingDistributionMetricTypeTest.kt
Outdated
Show resolved
Hide resolved
@travis79 |
So, for the longest time unsigned types were a "prototype" feature in kotlin, so we used signed types even though we never had a use case to record negative values. So I think any of the values coming across the FFI should be signed types because of this. What failures were you seeing on the Kotlin side, maybe that will help me to point you in the right direction to get this working with an |
5d1d0e3
to
9ff8e14
Compare
This was what I originally tried but tests were failing locally. Travis tested and said it looked fine for him and I want to see if CI runs.
Talked with @travis79 and looks like my issues were caused (potentially, unconfirmed) by gradle caching. I ran the Kotlin tests via So looks like the issue I was seeing was just a local thing, thanks @travis79 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I had just a couple of non-blocking nits, and I don't see a need to re-review this. 🎉
Co-authored-by: Travis Long <tlong@mozilla.com>
Update
DistributionData
object to includecount
so that a dev can easily check how many samples end up in the distribution. This change effects timing, memory, and custom distributions.