Python: Switch to maturin for all Python building/development #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
with-maturin
branch
8 times, most recently
from
0007bb1
to
e2644f3
Compare
perrymcmanis144
approved these changes
Jun 21, 2023
badboy
force-pushed
the
with-maturin
branch
4 times, most recently
from
b4a3056
to
77db015
Compare
maturin is a Python build tool (written in Rust), that can robustly handle building Python packages with UniFFI bindings. This gets rid of our highly custom `setup.py` setup, streamlines development and building of the Python package and ensures consistent generation of Wheel packages for release. This also combines all Python configuration into a single place: a top-level pyproject.toml
|
fwiw I pushed a locally-built package to pypi test here: https://test.pypi.org/project/glean-sdk/52.0.0/ IMO this is good to go. |
This breaks with the new setup. We're down to only 2 direct dependencies. We're "fine" for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on #2344)After the recent universal2 wheel work I realized how messy our Python setup is:
A big home-grown solution inside a
setup.pyreinventing half of Python package management all over again.There must be something better for it.
There is: maturin.
Tried and trusted in other projects, this tool can take care of most of the build and development hassles of a Python package with UniFFI bindings.
This PR switches our development tooling over to maturin, for both local development and on CI.
And while I was at it I also moved all Python tooling configuration into the one and only
pyproject.toml.This is not yet ready for merge, because:
Python 3_6 tests,Python 3_6 tests minimum dependenciesandPython 3_9 tests minimum dependenciesas those tests are gone.