Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1825298 - Add the Date header as late as possible before the uploader acts #2436

Merged
merged 4 commits into from Mar 31, 2023

Conversation

badboy
Copy link
Member

@badboy badboy commented Mar 30, 2023

No description provided.

@badboy badboy requested a review from a team as a code owner March 30, 2023 09:08
@badboy badboy requested review from chutten and removed request for a team March 30, 2023 09:08
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with changelog.

@badboy badboy force-pushed the 1825298/date-header-as-late-as-possible branch from 18b693f to eaec158 Compare March 31, 2023 10:22
@badboy badboy enabled auto-merge (rebase) March 31, 2023 10:23
We passed the wrong list of files.
This differed from the one passed to the `ktlint` command and thus
didn't actually correct the things that one complained about
@badboy badboy force-pushed the 1825298/date-header-as-late-as-possible branch from eaec158 to 4301d3a Compare March 31, 2023 10:36
@badboy badboy merged commit dfed924 into main Mar 31, 2023
32 of 33 checks passed
@badboy badboy deleted the 1825298/date-header-as-late-as-possible branch March 31, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants