Bug 1828528 - add TextMetric entry to private mod.rs #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrymcmanis144
force-pushed
the
textmetric_entry
branch
2 times, most recently
from
9028fa9
to
6c1724e
Compare
chutten
approved these changes
Apr 19, 2023
perrymcmanis144
force-pushed
the
textmetric_entry
branch
from
6c1724e
to
437a625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test just to make sure the private version of TextMetric was being used.
Do we have a canonical string for long entries? I'm not sure movie quotes are appropriate here