Bug 1839640 - Add new metric type: object #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
changed the title
|
There's still a couple of things I need to get in order for this to land, but it's good for a first review. |
chutten
requested changes
Jan 22, 2024
badboy
force-pushed
the
object-type
branch
2 times, most recently
from
24558ef
to
28830ef
Compare
badboy
commented
Jan 25, 2024
badboy
force-pushed
the
object-type
branch
3 times, most recently
from
6537fa2
to
4a8ac5e
Compare
badboy
force-pushed
the
object-type
branch
4 times, most recently
from
e6999c4
to
be6afe7
Compare
chutten
approved these changes
Feb 14, 2024
| /// Gets the currently stored value as JSON-encoded string. | ||
| /// | ||
| /// This doesn't clear the stored value. | ||
| pub fn test_get_value(&self, ping_name: Option<String>) -> Option<String> { |
There was a problem hiding this comment.
Comment: It does strike me as... asymmetric that we set a JsonValue but get a String. I understand why get is a String: glean-core doesn't know the structure. And I'm guessing set is a JsonValue because it's the strongest type we can manage.
There was a problem hiding this comment.
yeah, to be addressed in a followup
This allows to actually inspect the files after they have been sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires mozilla/glean_parser#587
Far from ready, requires tests and more work, e.g. APIs so we can properly implement it for C++ and JS.