Add missing parts for new events API #339

badboy · 2021-05-25T10:41:34Z

Quality: This PR builds and tests run cleanly
- make test runs without emitting any warnings
- make lint runs without emitting any errors
Tests: This PR includes thorough tests or an explanation of why it does not
Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
- Any breaking changes to language binding APIs are noted explicitly

glean_parser/swift.py

setup.py

…tion

…ntation

badboy requested a review from mdboom May 25, 2021 10:41

badboy mentioned this pull request May 25, 2021

Bug 1693486 - Implement new event extras API mozilla/glean#1603

Merged

5 tasks

badboy force-pushed the missing-event-imports branch 3 times, most recently from 5bd41f1 to 7e298ca Compare May 25, 2021 10:57

badboy mentioned this pull request May 27, 2021

Don't rely on setup.py for installation anymore #340

Merged

mdboom approved these changes May 28, 2021

View reviewed changes

glean_parser/swift.py Show resolved Hide resolved

setup.py Show resolved Hide resolved

badboy force-pushed the missing-event-imports branch 2 times, most recently from 7f21a68 to 726a124 Compare May 28, 2021 13:59

badboy added 10 commits May 28, 2021 16:01

Add missing import for new events API

3eb65f4

Kotlin: Use a plain Kotlin list in the generated interface implementa…

5474126

…tion

Generate additional generics for event metrics as required by impleme…

f064e79

…ntation

Swift: Fix keyword: val -> var

a8c8f7d

Swift: Use the right variable name in generated code

e1d03c4

Document new changes

4c4b760

Fix tests with new event API

9009294

Kotlin: Indentation fixes

c9f9b4e

Don't install jsonschema 4.

1601df4

Fix comment for Kotlin hack

f961433

badboy force-pushed the missing-event-imports branch from 726a124 to f961433 Compare May 28, 2021 14:01

badboy merged commit 13572c7 into main May 28, 2021

badboy deleted the missing-event-imports branch May 28, 2021 14:05

Provide feedback