Bug 1713398 - Enable custom distribution without a gecko_datapoint #346

badboy · 2021-06-10T12:55:42Z

Rust doesn't have named arguments, so we need to ensure they are in
order.

Quality: This PR builds and tests run cleanly
- make test runs without emitting any warnings
- make lint runs without emitting any errors
Tests: This PR includes thorough tests or an explanation of why it does not
Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
- Any breaking changes to language binding APIs are noted explicitly

Rust doesn't have named arguments, so we need to ensure they are in order.

glean_parser/util.py

badboy added 2 commits June 10, 2021 13:40

Order extra metric arguments in the order they are expected

459cd1e

Rust doesn't have named arguments, so we need to ensure they are in order.

Enable custom distribution without a gecko_datapoint

f597980

badboy requested a review from Dexterp37 June 10, 2021 12:58

badboy mentioned this pull request Jun 10, 2021

Bug 1713398 - glean_parser update & desktop custom distribution API docs mozilla/glean#1679

Merged

Dexterp37 approved these changes Jun 10, 2021

View reviewed changes

glean_parser/util.py Show resolved Hide resolved

badboy merged commit f6915ad into main Jun 11, 2021

badboy deleted the enable-custom-dist branch June 11, 2021 10:38

Provide feedback