Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1827852 - Allow metadata to configure precise timestamps #592

Merged
merged 1 commit into from Sep 13, 2023
Merged

Bug 1827852 - Allow metadata to configure precise timestamps #592

merged 1 commit into from Sep 13, 2023

Conversation

badboy
Copy link
Member

@badboy badboy commented Jun 28, 2023

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@badboy badboy mentioned this pull request Jun 28, 2023
Merged
@badboy badboy force-pushed the precise-timestamps-optout branch from 95dbcd5 to 1053036 Compare July 12, 2023 09:06
travis79
travis79 reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see changes to the rust and swift jinja templates, does this need to be done for the other templates too?

@badboy
Copy link
Member Author

badboy commented Sep 12, 2023

I only see changes to the rust and swift jinja templates, does this need to be done for the other templates too?

hah, good that you ask. the other templates actually use ping_args from the utils.py and iterate over that list to generate arguments.

travis79
travis79 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@badboy badboy enabled auto-merge (rebase) September 13, 2023 12:34
@badboy badboy merged commit be77137 into main Sep 13, 2023
7 checks passed
@badboy badboy deleted the precise-timestamps-optout branch September 13, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travis79 travis79 travis79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@badboy @travis79