Bug 1855046 - Allow unit only for the quantity metric #630
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
disallow-unit-everywhere-but-quantity
branch
from
be4ff53
to
5b32377
Compare
badboy
force-pushed
the
disallow-unit-everywhere-but-quantity
branch
from
5b32377
to
8f3b25a
Compare
This is implemented the same way time_unit is implemented for others:
The specific metric class takes the argument, not the generic one.
Because the schema enforces `unit` to be required for `quantity` we can
just `pop` it with the guarantee it's there.
The error message for other metrics if they do set `unit` is less nice:
Metric.__init__() got an unexpected keyword argument 'unit'
But that's in line with what `time_unit` also does.
badboy
force-pushed
the
disallow-unit-everywhere-but-quantity
branch
from
8f3b25a
to
813dcfd
Compare
chutten
approved these changes
Oct 3, 2023
badboy
added a commit
that referenced
this pull request
Nov 3, 2023
This partially reverts #630 (and subsequent fixes) and should unblock all failures in probe-scraper and co.
badboy
added a commit
that referenced
this pull request
Nov 3, 2023
This partially reverts #630 (and subsequent fixes) and should unblock all failures in probe-scraper and co.
3 tasks
badboy
added a commit
that referenced
this pull request
Nov 3, 2023
This partially reverts #630 (and subsequent fixes) and should unblock all failures in probe-scraper and co.
badboy
added a commit
that referenced
this pull request
Nov 3, 2023
This partially reverts #630 (and subsequent fixes) and should unblock all failures in probe-scraper and co.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented the same way time_unit is implemented for others: The specific metric class takes the argument, not the generic one.
Because the schema enforces
unitto be required forquantitywe can justpopit with the guarantee it's there.The error message for other metrics if they do set
unitis less nice:But that's in line with what
time_unitalso does.10 minute explore of what it takes.Needs a changelog entry and probably an additional test to cover it. I'd appreciate if someone is taking this off my hands.