Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add definitions of SDK metrics for server-side Glean #695

Merged
merged 2 commits into from
May 3, 2024
Merged

Add definitions of SDK metrics for server-side Glean #695

merged 2 commits into from
May 3, 2024

Conversation

akkomar
Copy link
Collaborator

@akkomar akkomar commented Apr 25, 2024

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@akkomar akkomar mentioned this pull request Apr 25, 2024
Merged
@akkomar akkomar marked this pull request as ready for review April 25, 2024 13:28
@akkomar akkomar requested a review from badboy April 25, 2024 13:28
badboy
badboy approved these changes Apr 30, 2024
View reviewed changes
server_telemetry/sdk-metrics-compat.yaml Outdated Show resolved Hide resolved
@badboy badboy enabled auto-merge (squash) May 3, 2024 11:32
@badboy badboy merged commit 6fe8a8f into main May 3, 2024
8 checks passed
@akkomar akkomar deleted the server_metrics branch May 6, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badboy badboy badboy approved these changes

@travis79 travis79 travis79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@akkomar @badboy @travis79