Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1894270 - ping_schedule: Gracefully handle missing ping #705

Merged
merged 1 commit into from
May 13, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented May 8, 2024

This is for those cases where the referenced ping is not part of the same ping definition, e.g. builtin pings.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

This is for those cases where the referenced ping is not part of the
same ping definition, e.g. builtin pings.
@badboy badboy requested a review from travis79 May 13, 2024 11:00
@badboy badboy merged commit 43d6346 into main May 13, 2024
8 checks passed
@badboy badboy deleted the scheduler/gracefully-handle-missing branch May 13, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants