Remove unnecessary bedrock tests and fix broken redirect tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswinarton
changed the title
jswinarton
commented
Oct 23, 2023
| @@ -198,7 +198,7 @@ testScenarios.forEach((scenario) => { | |||
| test(`Verify redirect for ${baseUrl}/r/vpn/update/ios, C1539669`, async () => { | |||
| await verifyRedirectUrl( | |||
| `${baseUrl}/r/vpn/update/ios`, | |||
| 'https://apps.apple.com/us/app/firefox-private-network-vpn/id1489407738' | |||
| 'https://apps.apple.com/us/app/mozilla-vpn-secure-private/id1489407738' | |||
There was a problem hiding this comment.
I'm not sure when this changed, but it was not a Guardian change -- the former is now a redirect to the latter (and redirect tests here assert against the last redirect URL in the chain). I would presume this changed as part of the FPN removal.
Gela
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the tests passing again. Fixes VPN-5517.
After discussion with @alexgibson and Rebecca B last week, we determined that Bedrock already has a robust suite of tests that assert against various content elements on the VPN landing page, and there is no need for us to maintain a separate set of tests that ultimately do the same thing. Therefore, these have been removed.
There were a couple redirect tests that had also gone out of date due to FPN sunset related changes, so those have also been fixed.