Fix prop types for popovers

mozilla · Oct 21, 2020 · adfc22b · adfc22b
1 parent 0501465
commit adfc22b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/src/react-components/room/PlacePopover.js b/src/react-components/room/PlacePopover.js
@@ -1,4 +1,5 @@
 import React from "react";
+import PropTypes from "prop-types";
 import { ButtonGridPopover } from "../popover/ButtonGridPopover";
 import { Popover } from "../popover/Popover";
 import { ToolbarButton } from "../input/ToolbarButton";
@@ -34,5 +35,5 @@ export function PlacePopoverButton({ items }) {
 }
 
 PlacePopoverButton.propTypes = {
-  items: ButtonGridPopover.propTypes.items
+  items: PropTypes.array.isRequired
 };
diff --git a/src/react-components/room/PlacePopoverContainer.js b/src/react-components/room/PlacePopoverContainer.js
@@ -81,5 +81,5 @@ PlacePopoverContainer.propTypes = {
   hubChannel: PropTypes.object.isRequired,
   scene: PropTypes.object.isRequired,
   mediaSearchStore: PropTypes.object.isRequired,
-  pushHistoryState: PropTypes.object.isRequired
+  pushHistoryState: PropTypes.func.isRequired
 };
diff --git a/src/react-components/room/SharePopover.js b/src/react-components/room/SharePopover.js
@@ -57,14 +57,5 @@ export function SharePopoverButton({ items }) {
 }
 
 SharePopoverButton.propTypes = {
-  items: PropTypes.arrayOf(
-    PropTypes.shape({
-      id: PropTypes.string.isRequired,
-      icon: PropTypes.elementType.isRequired,
-      color: PropTypes.string,
-      name: PropTypes.string.isRequired,
-      active: PropTypes.bool,
-      onSelect: PropTypes.func
-    })
-  ).isRequired
+  items: PropTypes.array.isRequired
 };