Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX Enhancement] Fix Button Inconsistencies #1482

Closed
flowpoly opened this issue Jun 26, 2019 · 4 comments · Fixed by #1874
Closed

[UX Enhancement] Fix Button Inconsistencies #1482

flowpoly opened this issue Jun 26, 2019 · 4 comments · Fixed by #1874
Labels

Comments

@flowpoly
Copy link

Some buttons do not have the first letter capitalized, but others do. The standard should be "Share" and not "share".

Buttons affected:
Share
Close (when signing in successfully)
Choose Scene (button below the 'share' button when Choosing a Device)
Delete Avatar (when creating a new avatar, the styling here is also different)
Object's Menu (pin, clone, open link)

@Parikshit-Hooda
Copy link

Please let me know the directory and file where I can find the said buttons. I am willing to fix this issue.

@gfodor
Copy link
Contributor

gfodor commented Jul 1, 2019

The copy for the buttons can largely be found in src/assets/translations.data.json -- thanks for offering to help!

@zufishanali
Copy link
Contributor

Hi, is this issue still open? If no one has started working on it yet, I would like to attempt it.

Thanks,
Zufishan

@SparshKat
Copy link
Contributor

SparshKat commented Dec 23, 2019

Hi, @flowpoly, i am willing to work on the given issue, is this still open and not assigned to anyone? However i checked on the few errors mentioned by you before hand and i can't seem to find few errors like -

  • Close (when signing in successfully)

  • Delete Avatar (when creating a new avatar, the styling here is also different)

  • Object's Menu (pin, clone, open link)

If you could point out and clarify a bit more on the following issues, i'll right away fix them and open a PR.

gfodor added a commit that referenced this issue Jan 10, 2020
Fixes #1482 - Updated Some Button Inconsistencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants