Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] 'Use Avatar' button should have some kind of feedback #1506

Open
misslivirose opened this issue Jul 5, 2019 · 8 comments
Open
Labels
enhancement work that enhances an existing feature good first issue

Comments

@misslivirose
Copy link
Contributor

Right now, there's no way that you can tell that your selection has been successful, unless you look down at yourself. Suggest some kind of visual or audio feedback.

@misslivirose misslivirose added enhancement work that enhances an existing feature good first issue labels Jul 5, 2019
@SparshKat
Copy link
Contributor

Yes, i saw this issue and it's a grave issue. @brianpeiris @gfodor what do you guys suggest to do for this issue. I am willing to contribute to this too.
One suggestion is that i can make some text come up when someone click the use avatar button just like whenever someone clicks the copy avatar button.

@gfodor
Copy link
Contributor

gfodor commented Jan 7, 2020

I'm actually not sure what we want to do here. I don't think a text notification is the right approach, since we don't really have a place for it nor does that really convey the new avatar you've chosen is now your embodiment.

I think we probably should re-visit this issue if/when we decide how we want to enable users to see their own avatar. Currently you do it via opening the camera, which isn't really a great UX. Once that is decided upon, there's a good chance whatever mechanic we do here will need to incorporate it so the user can see the new avatar they've changed to using it.

@emclaren
Copy link
Contributor

emclaren commented Jan 8, 2020

Personally, I would prefer a little bit of audio feedback, similar to what's used when you pin an object. It would be nice to have some indication that your selection was successful (particularly when you are select an avatar that has been placed in-world, as I never know if I clicked it correctly)

@gfodor
Copy link
Contributor

gfodor commented Jan 8, 2020 via email

@SparshKat
Copy link
Contributor

Could you once pin point to the file consisting of the 3d interactive VR file where i could dabble with changes with the avatar? @gfodor @emclaren

@SparshKat
Copy link
Contributor

Sorry i wasn't able to find the correct file to submit a PR, a quick response would do the job :)

@johnshaughnessy
Copy link
Contributor

The "use avatar" button is the open-media-button :

https://github.com/mozilla/hubs/blob/master/src/components/open-media-button.js

@SparshKat
Copy link
Contributor

Screenshot 2020-02-09 at 5 14 47 PM

I can see no "Use Avatar" button anymore and the changing of avatar has been done by opening a link on the avatar. @johnshaughnessy @gfodor how should i contribute to it now? :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement work that enhances an existing feature good first issue
Projects
None yet
Development

No branches or pull requests

5 participants