New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] 'Use Avatar' button should have some kind of feedback #1506
Comments
Yes, i saw this issue and it's a grave issue. @brianpeiris @gfodor what do you guys suggest to do for this issue. I am willing to contribute to this too. |
I'm actually not sure what we want to do here. I don't think a text notification is the right approach, since we don't really have a place for it nor does that really convey the new avatar you've chosen is now your embodiment. I think we probably should re-visit this issue if/when we decide how we want to enable users to see their own avatar. Currently you do it via opening the camera, which isn't really a great UX. Once that is decided upon, there's a good chance whatever mechanic we do here will need to incorporate it so the user can see the new avatar they've changed to using it. |
Personally, I would prefer a little bit of audio feedback, similar to what's used when you pin an object. It would be nice to have some indication that your selection was successful (particularly when you are select an avatar that has been placed in-world, as I never know if I clicked it correctly) |
That sounds like a good start! Would you like to give it a shot
@DevilInside? You can just add the camera snapshot sound effect to start to
see how that feels.
…On Wed, Jan 8, 2020 at 1:42 PM elgin mclaren ***@***.***> wrote:
Personally, I would prefer a little bit of audio feedback, similar to
what's used when you pin an object. It would be nice to have some
indication that your selection was successful (particularly when you are
select an avatar that has been placed in-world, as I never know if I
clicked it correctly)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1506?email_source=notifications&email_token=AABVW5GOY5KPA2JH63OWLW3Q4ZCFDA5CNFSM4H6NHSR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIOCP5I#issuecomment-572270581>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABVW5CQS6M5YKNDMLMLF2LQ4ZCFDANCNFSM4H6NHSRQ>
.
|
Sorry i wasn't able to find the correct file to submit a PR, a quick response would do the job :) |
The "use avatar" button is the open-media-button : https://github.com/mozilla/hubs/blob/master/src/components/open-media-button.js |
I can see no "Use Avatar" button anymore and the changing of avatar has been done by opening a link on the avatar. @johnshaughnessy @gfodor how should i contribute to it now? :( |
Right now, there's no way that you can tell that your selection has been successful, unless you look down at yourself. Suggest some kind of visual or audio feedback.
The text was updated successfully, but these errors were encountered: