Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing scene to Hubs Room URL instead of Scene URL breaks room #1877

Closed
emclaren opened this issue Nov 1, 2019 · 4 comments · Fixed by #1985
Closed

Changing scene to Hubs Room URL instead of Scene URL breaks room #1877

emclaren opened this issue Nov 1, 2019 · 4 comments · Fixed by #1985
Assignees
Labels
bug P1 Address as quickly as possible

Comments

@emclaren
Copy link
Contributor

emclaren commented Nov 1, 2019

Description
When you change the scene using the "/scene" command, if you use a URL that links to a Hubs Room instead of a Scene by mistake, the room breaks and will no longer load.

It throws an error that says "SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data"

To Reproduce
Steps to reproduce the behavior:

  1. Go to Hubs room
  2. type /scene
  3. Refresh the page, it will no longer load

Expected behaviour
I expect the scene to not change, and when I refresh the scene it will remain as the last-used scene, or just a big empty room. I do not expect it to make the room URL break.

Additional context
This error happened to Elgin while testing out scenes, but it has also been flagged by the community

@emclaren emclaren added bug needs triage For bugs that have not yet been assigned a fix priority labels Nov 1, 2019
@misslivirose misslivirose added P1 Address as quickly as possible and removed needs triage For bugs that have not yet been assigned a fix priority labels Nov 13, 2019
@misslivirose
Copy link
Contributor

Given that this fairly catastrophically impacts the room, I think it would be good to handle this in a way that doesn't break the room.

@emclaren
Copy link
Contributor Author

Just realized as well - there is no way of removing a room that was broken like this from the list of favourites (since you need to open the room to favourite/unfavourite). My list is stuck looking like this
Screen Shot 2019-11-18 at 7 57 54 AM

@misslivirose
Copy link
Contributor

@emclaren just opened a new issue for removing favorites (#1912 )

@misslivirose
Copy link
Contributor

When we fix this, we should incorporate the suggestions in #811 as well in terms of general error messaging back to the user when a URL isn't going to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P1 Address as quickly as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants