New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room does not load if you use a Sketchfab URL in custom scene options dialog #811

Open
brianpeiris opened this Issue Jan 1, 2019 · 8 comments

Comments

Projects
None yet
2 participants
@brianpeiris
Copy link
Member

brianpeiris commented Jan 1, 2019

A user attempted to use a sketchfab model in the "Create a Room" options dialog and was confused that it didn't work, since we support loading sketchfab models in-room. Currently, we just spin on the loading page when you try to do this.

We should either disallow using sketchfab URLs in that dialog, or actually resolve the sketchfab model and use it

@brianpeiris brianpeiris added the bug label Jan 1, 2019

@Mordax

This comment has been minimized.

Copy link

Mordax commented Jan 14, 2019

I'd like to try working on this. I'm assuming it may be nicer to actually have it work and load the scene rather than removing it completely.

@brianpeiris

This comment has been minimized.

Copy link
Member Author

brianpeiris commented Jan 14, 2019

Thanks @Mordax,

One reason we may actually want to disallow sketchfab URLs is because sketchfab models often have wildly varying scales, so most sketchfab scenes may not work as expected if you just load them through this method.
Our current recommendation for using sketchfab models as scenes is to go through Spoke, which gives you other benefits, like an auto-generated nav mesh.

So, I'm not entirely sure which choice we should make. I'll let the rest of the team chime in on this.

@Mordax

This comment has been minimized.

Copy link

Mordax commented Jan 15, 2019

Thanks @brianpeiris for responding so quickly - that's a good point, I didn't consider that to be a problem. What's the current dimensions for generating a Hubs-ready scene? Can we do some on the fly resizing for people importing it? Or pull up a dialogue box saying the size isn't the best for a Hubs scene?

@brianpeiris

This comment has been minimized.

Copy link
Member Author

brianpeiris commented Jan 16, 2019

There aren't any limits on scene size in Hubs, and I don't see how we could automatically scale a sketchfab model to an appropriate scale, since you'd really have to understand the content of the scene.

@Mordax

This comment has been minimized.

Copy link

Mordax commented Jan 27, 2019

@brianpeiris Sorry for the late response - what do you think about replacing the options with something to let the user know that they should generate their pre existing room in Spoke? If not, I'm also unsure if it's fair to make users go through putting their existing rooms through Spoke. I spoke with some fellow competitors during the VR Clubhouse challenge and they seemed to have problems with generating accurate floor plans.

@brianpeiris

This comment has been minimized.

Copy link
Member Author

brianpeiris commented Jan 29, 2019

I think we can compromise -- if a user enters a Sketchfab URL (or Google Poly URL), show a message directing them to use Spoke, otherwise, assume that the URL points to a GLTF and load it directly using the existing mechanism.

We definitely want to improve Spoke and make it the preferred option, not to force users to use it, but because it ought to actually be a better experience. @robertlong is actually working on nav mesh improvements right now.

@Mordax

This comment has been minimized.

Copy link

Mordax commented Jan 31, 2019

@brianpeiris Does the hubs have a real time chat that's relatively populated (irc, discord, etc) where I can shoot some quick questions? The slack discord invite doesn't seem to work.

@brianpeiris

This comment has been minimized.

Copy link
Member Author

brianpeiris commented Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment