Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin does not function for screenshares #5063

Open
matthewbcool opened this issue Jan 30, 2022 · 6 comments
Open

Pin does not function for screenshares #5063

matthewbcool opened this issue Jan 30, 2022 · 6 comments
Assignees
Labels
bug P1 Address as quickly as possible qa-triaged Label for issues that were triaged by QA S2 Severe UX Feedback

Comments

@matthewbcool
Copy link
Contributor

matthewbcool commented Jan 30, 2022

Description
Being unable to pin a screen share is very inconvenient for anyone presenting their screen to a group of people in hubs. People in the space will often accidentally take control of the object and move it unintentionally when they are moving.

At the very least we should remove the option or give some kind of user feedback explaining that you can't pin screenshares.

To Reproduce
Steps to reproduce the behavior:

  1. Click screen share and select your screen
  2. select 'pin' from the object menu

Expected behavior
When selecting 'Pin' on a screen share, expecting to either pin the screen share or have some kind of feedback to the user why it is not pinning as expected.

Hardware

  • Device: [Desktop]
  • OS: [MacOS]
  • Browser: [Firefox, chrome]

┆Issue is synchronized with this Jira Task

@matthewbcool matthewbcool added bug needs triage For bugs that have not yet been assigned a fix priority jira-hubs UX Feedback labels Jan 30, 2022
@Exairnous
Copy link
Contributor

It's great to see this documented here! While either of the expected results would help, I actually think pinning should be separated out into two actions:

  1. Locking. All users can click a button to lock an object's spatial coordinates (location, rotation, scale). Whether moving should be allowed when the object is locked but the spacebar is pressed should be discussed (I lean towards yes because it's convenient and prevents throwing).
  2. Pinning. Users click on "Pin" to pin the object to the room (can also trigger a lock as well to preserve the current behavior, but it might be nice to not automatically lock the object when pinning, or allow unlocking while still pinned, and only save the object's coordinates when the object's owner exits the room). Only logged in users can pin objects the same as it is currently.

With the separation, it becomes easy to just have the locking button, but omit the pinning button for screen shares. I think this, along with a note in the docs, should be enough to let users know what's going on.

@Dayk0
Copy link

Dayk0 commented Feb 18, 2022

This is a very annoying problem currently for the use of hubs.

@docEdub
Copy link

docEdub commented Feb 27, 2022

Ya, makes screen sharing unusable with large groups that don't know not to click on it.

@yinchy
Copy link

yinchy commented Feb 27, 2022

The lack of Pin or Lock for sharescreen is very disruptive to user experience.
The modality of the UI makes it easy for audience members to accidentally grab and manipulate the presenter's sharescreen.
It almost seems that the default behaviour should be Locked to "only-screenshare-creator" can manipulate. and the presenter can "unlock" it if they wish.

@yengalvez
Copy link

Why it isn't fixed? It's annoying and impossible to use with new groups. This is a big issue.

@SV-AndreiC SV-AndreiC added the S2 Severe label Apr 28, 2022
@cornelionce cornelionce added the qa-triaged Label for issues that were triaged by QA label May 2, 2022
@keianhzo keianhzo self-assigned this May 9, 2022
@emclaren emclaren added the P1 Address as quickly as possible label May 25, 2022
@johnshaughnessy johnshaughnessy removed needs triage For bugs that have not yet been assigned a fix priority jira-hubs labels Jun 6, 2022
@Exairnous
Copy link
Contributor

Exairnous commented Dec 8, 2023

A possible workaround for presenters is to put a transparent image with the controls enabled in your scene in front of the media frame you'll be using to present the screen share. This will intercept your clicks and prevent grabbing/throwing the screen share from the side you put it on, while still allowing people to see/focus on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P1 Address as quickly as possible qa-triaged Label for issues that were triaged by QA S2 Severe UX Feedback
Projects
None yet
Development

No branches or pull requests