Refactor Pen Tool to use triangles instead of triangle strips for rendering #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-triangles-refactor
johnshaughnessy
approved these changes
Sep 11, 2020
| this.current.attributes[key].array[pos++] = this.current.attributes[key].array[i]; | ||
| if (key === "index") { | ||
| //index needs to be handled specially | ||
| this.current.index.array[pos++] = this.current.index.array[i] - idx.position - 1; |
There was a problem hiding this comment.
What does this line do / why are indices handled differently? I'm having a hard time keeping track of idx, prevIdx, this.idx and all of their .index attributes
There was a problem hiding this comment.
unlike position, normals or colors, indexes are not accessible on the geometry.attributes property, they're instead accessed via geometry.index directly, or via getIndex() or setIndex()
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three.js as of r112 has removed
drawModefrom meshes, thus deprecating support for triangle-strip rendering. This updatesnetworked-drawingandsharedbuffergeometryto use indexed triangles instead.This also moves the serialize drawing button on the drawing hover menu so that it doesn't overlap with the new media refresh button.