Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing space to match PeopleSidebar #4333

Merged

Conversation

rawnsley
Copy link
Contributor

@rawnsley rawnsley commented Jun 16, 2021

Apologies for being pedantic, but it's been bothering me for a while.

┆Issue is synchronized with this Jira Task

@yakyouk
Copy link
Contributor

yakyouk commented Jun 23, 2021

Apologies for being pedantic, but it's been bothering me for a while.

haha, was bothering me too.
Suggesting this:

        <FormattedMessage
          id="content-menu.people-menu-button"
          defaultMessage="People ({presenceCount})"
          values={{ presenceCount: props.presenceCount }}
        />

@netpro2k
Copy link
Contributor

I agree with @yakyouk's suggestion. Either that or adding the space outside of the translated message. Otherwise all translation will need to remember to include this trailing space.

@rawnsley
Copy link
Contributor Author

I agree with @yakyouk's suggestion. Either that or adding the space outside of the translated message. Otherwise all translation will need to remember to include this trailing space.

Agreed and updated. Thanks @yakyouk

@johnshaughnessy johnshaughnessy merged commit 1408e4a into Hubs-Foundation:master Sep 3, 2021
@rawnsley rawnsley deleted the people-missing-space branch September 6, 2021 12:22
@Softvision-GeluHaiduc
Copy link
Contributor

I have verified this using Windows 10 on the latest releases for Firefox and Chrome browsers, I tested using different languages.
While testing I encountered 2 new issues that I logged here #4646 and #4647

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified-fixed Label for QA to mark verified fixed issues label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external jira-hubs pull-request [QA]:Verified-fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants