Fast Room Switching #4347
Merged
Fast Room Switching #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat. Any sense when this will come to hubs cloud? |
|
would love to see this working also in Oculus Quest... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now switch rooms without loading a new page or going back through the entry flow. This makes room switching much faster and less painful! You currently need to opt into this feature by enabling it in preferences.
This PR adds the ability to switch rooms without a page refresh. This is done by switching phoenix channel topics, disconnecting from dialog, and connecting to a new dialog room. We also have to do work to clean up objects in the room, handle pinned objects, etc. There is still room to make this faster, but it is already much better than the current flow.
Associated backend change Hubs-Foundation/reticulum#507