Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pinning animations if already running #4642

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Conversation

keianhzo
Copy link
Contributor

Fixes #4059

When clicking on the pager next/prev while the previous animations os still running we use the updated object scale as the size reference and we end up with a different scaled object when the animations end.

This PR fixes just dropping animations if the previous animations are still running.

@netpro2k
Copy link
Contributor

Haven't looked at this code in a long time so not sure how hard it is, but ideally we wouldn't even show the pin animation in this case. It's just an internal technical detail that the object is being re-pinned as part of paging (since its component data has changed and needs to be saved). From a user perspective they should only see the pin animation when they actually click the pin/unpin button.

@keianhzo
Copy link
Contributor Author

@netpro2k That makes sense, I didn't really know what was the expected behavior. I've updated to not animate but I kept the code to check if the animation are already running to avoid this scaling issue in case we can get multiple events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A pinned PDF file is enlarged if the next/previous page button is clicked repeatedly
3 participants