Introduce Audio PanningQuality preference #5454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnshaughnessy
approved these changes
May 25, 2022
|
Thanks for reviewing. Your comments make sense to me. Updated, thanks. |
WebAudio and Three.js uses HRTF panning model for Panner audios by default. But HRTF is said to be better quality but much more costly than another pannind model equalpower. Some users, especially low-end or mobile device users, may think they want to set equalpower panning model for better performance by sacrificing the audio panning quality. This commit introduces Audio PanningQuality preference. The high quality corresponds to HRTF while the low quality corresponds to equalpower.
|
@johnshaughnessy Would you mind if reviewing again to check if the updates look ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5278
WebAudioandThree.jsusesHRTFpanning model for Panner audios by default. ButHRTFis said to be better quality but much more costly than another pannind modelequalpower. Some users, especially low-end or mobile device users, may think they want to setequalpowerpanning model for better performance by sacrificing the audio panning quality.This PR introduces Audio PanningQuality preference. The high quality corresponds to
HRTFwhile the low quality corresponds toequalpower.Additional Context
HRTFso far. We may think we want to setequalpower(on mobile devices) by default. But I want to think of the appropriate default value after testing across the devices.