MobileStandardMaterial #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong
commented
Sep 6, 2018
src/components/gltf-model-plus.js
Outdated
| @@ -76,7 +77,7 @@ function cloneGltf(gltf) { | |||
|
|
|||
| cloneSkinnedMesh.bind(new THREE.Skeleton(orderedCloneBones, skeleton.boneInverses), cloneSkinnedMesh.matrixWorld); | |||
|
|
|||
| cloneSkinnedMesh.material = skinnedMesh.material.clone(); | |||
| // cloneSkinnedMesh.material = skinnedMesh.material.clone(); | |||
There was a problem hiding this comment.
I needed to comment this line out to get the ShaderMaterial to work. This means that models from the same url will share a material and changing the uniforms of one material will affect the other. Because we are no longer using the audio feedback for making the avatar's head brighter, I think this is safe? Maybe we are modifying materials somewhere else?
gfodor
reviewed
Sep 6, 2018
| @@ -256,8 +257,12 @@ async function loadGLTF(src, contentType, preferredTechnique, onProgress) { | |||
|
|
|||
| gltf.scene.traverse(object => { | |||
| if (object.material && object.material.type === "MeshStandardMaterial") { | |||
| object.material.envMap = envMap; | |||
| object.material.needsUpdate = true; | |||
| if (preferredTechnique === "KHR_materials_unlit") { | |||
There was a problem hiding this comment.
see this wasn't so hacky! :)
(thanks for the PR when you are technically on vacation!)
netpro2k
approved these changes
Oct 22, 2018
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces any StandardMaterials with the MobileStandardMaterial when on low quality mode (mobile and standalone). This improves performance of glTF models loaded via the media tools that do not use
MOZ_alt_materialsandKHR_materials_unlit.The MobileStandardMaterial currently uses an unlit shading model. It uses the
color,map,aoMap,aoMapIntensity,emissive,emissiveMap, andopacityfields from the StandardMaterial. The result is visually similar to the output ofgltf-unlit-generator.We could also use this material instead of using
gltf-unlit-generatorandMOZ_alt_materialsin our art pipeline. It would result in downloading more textures and a slightly more expensive shader, but can be used in all situations without export-time generation of an unlit map.Future versions of MobileStandardMaterial could also use the metallic, roughness, and normal maps in a more efficient manner than the StandardMaterial. Disabling dynamic lighting and using a cheaper approximate BRDF will improve the performance while still looking physically correct.