Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Add a test for DNT-compliant trackers #15

Merged
merged 2 commits into from May 2, 2016
Merged

Add a test for DNT-compliant trackers #15

merged 2 commits into from May 2, 2016

Conversation

fmarier
Copy link

@fmarier fmarier commented Apr 28, 2016

@fmarier
Copy link
Author

fmarier commented Apr 28, 2016

@bensternthal could I please get a review on this new addition to the tracker test page?

@bensternthal
Copy link
Contributor

JS seems ok, 2 things I found:

  1. dntcompliant-test took a while to load, I assumed this was a bug (I did not understand the elipses meant loading)
  2. Testing locally in private browsing only one bullet is green. (see screenshot)
  3. The text states "both of these should be green:" but then there are 3 bullets. Both = 2.

screen shot 2016-04-28 at 3 09 22 pm

@fmarier
Copy link
Author

fmarier commented Apr 28, 2016

dntcompliant-test took a while to load, I assumed this was a bug (I did not understand the elipses meant loading)

This should be faster once the file actually exists, but I'll bring the timer down to 3 seconds.

Testing locally in private browsing only one bullet is green. (see screenshot)

That's expected because the whitelist that makes this test pass relies on the URL of the page being itisatrap.org.

The text states "both of these should be green:" but then there are 3 bullets. Both = 2.

Good catch! I'll rephrase this to say that the first two should be green in Fx 42+ and all three should be green in Fx 49+.

@fmarier
Copy link
Author

fmarier commented Apr 28, 2016

@bensternthal This new version fixes the things you found in #15 (comment).

@bensternthal
Copy link
Contributor

bensternthal commented May 2, 2016

R+

@fmarier fmarier merged commit 1363e89 into mozilla:master May 2, 2016
@fmarier fmarier deleted the dntcompliant branch May 2, 2016 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants