Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Add its-a-tracker.html to test that Tracking Protection is working #6

Merged
merged 6 commits into from Sep 2, 2015
Merged

Add its-a-tracker.html to test that Tracking Protection is working #6

merged 6 commits into from Sep 2, 2015

Conversation

fmarier
Copy link

@fmarier fmarier commented Aug 13, 2015

Platform QA will be using this page to verify that the tracking protection lists are working correctly.

https://bugzilla.mozilla.org/show_bug.cgi?id=1149825

@fmarier
Copy link
Author

fmarier commented Sep 2, 2015

@bensternthal

@bensternthal
Copy link
Contributor

So I can't test the JS locally but just viewing in a browser looks OK with 1 minor nit.
You may want to change the UL to have "list-style: inside". Right now the list element circles appear to the left of the copy margin. See below screenshot.

If this is not an issue for you we can merge. Just comment and let me know.

screen shot 2015-09-02 at 3 56 06 pm

<!-- start #header -->
<div id="header">
<div>
<h1><a href="http://www.mozilla.org/firefox/" title="Back to home page">Mozilla Firefox</a></h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit indentation

@fmarier
Copy link
Author

fmarier commented Sep 2, 2015

These last two commits should take care of the bullets and the indentation.

@bensternthal
Copy link
Contributor

Looks good R+

I will email you instructions for requesting this be pushed live.

bensternthal added a commit that referenced this pull request Sep 2, 2015
Add its-a-tracker.html to test that Tracking Protection is working
@bensternthal bensternthal merged commit 968014c into mozilla:master Sep 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants