Remove multimap dependency #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, the changes looks great. I'll test to build this today with my additional fix about the publisher reconnecting. |
|
I actually deployed just this branch on my server and asked everyone to do some tests. I'll let you know if there is any issue. |
|
OK, I'll merge it if it seems like it's working well for you. |
|
My colleague did the tests with all his devices yesterday. He didn't have any weird issues, so that's cool. Yes, you can merge. Thank you very much! |
|
Still no issues. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't really pulling its weight, and killing it decreases the surface area for bugs like #62.
Also now we don't leak an empty vec in maps for every user and room that ever exists which is nice.