Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional metrics during instrumentation of clients (#191) #192

Closed
wants to merge 1 commit into from

Conversation

bsieber-mozilla
Copy link
Contributor

@bsieber-mozilla bsieber-mozilla commented Aug 4, 2022

In this PR we can now push metrics of successful jira calls and exceptions

@leplatrem does this make sense? Can success rate already be determined by existing metrics?

@leplatrem leplatrem changed the title Adding additional metrics during instrumentation of clients Adding additional metrics during instrumentation of clients (#191) Aug 4, 2022
@leplatrem
Copy link
Contributor

@leplatrem does this make sense? Can success rate already be determined by existing metrics?

I asked Ben here whether having these high level operations are enough (instead of client SDK methods calls).

If yes, then we should probably only add a fail operation, that we log when an exception is raised in runner.
If not, then maybe adjust this PR to add logger calls instead of StatsD metrics, since BigQuery seems to be the way to go for this kind of reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants