Adding Default Action #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
reviewed
Mar 25, 2022
leplatrem
reviewed
Mar 28, 2022
This was referenced Mar 30, 2022
leplatrem
reviewed
Mar 30, 2022
|
Thanks @leplatrem; I've resolved the comments in the most recent commit I believe. |
leplatrem
reviewed
Mar 30, 2022
There was a problem hiding this comment.
There are a couple of things that can still be improved I think, if you still have some forces ;)
- the fact that we return 201 on errors. See my comment https://github.com/mozilla/jira-bugzilla-integration/pull/31/files#r838330014
- the fact that we refetch/parse the bug in the action code https://github.com/mozilla/jira-bugzilla-integration/pull/31/files#r838340107
- the way jira and bugzilla are mocked in tests
We've never been so close ;)
bsieber-mozilla
commented
Mar 31, 2022
There was a problem hiding this comment.
Thanks again @leplatrem for your review; I've added some comments--and willing to further adjust, but I think most of the comments have been resolved in the most recent commit.
leplatrem
reviewed
Mar 31, 2022
bsieber-mozilla
commented
Apr 1, 2022
There was a problem hiding this comment.
@leplatrem I went through and made some changes based on your most recent comments.
I tried to add the suggested helper as an injected method in the bugzilla client returned from the get_bugzilla call, but something seemed off with that approach.
leplatrem
approved these changes
Apr 1, 2022
Merged
AshitaSingamsetty
pushed a commit
to fidelity-contributions/mozilla-jira-bugzilla-integration
that referenced
this pull request
Apr 13, 2023
…iders-issue Bugfix/terraform providers issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.