bug 1121918 - code review cleanups

mdn · Jan 26, 2015 · 2ed192c · 2ed192c
1 parent ccf9992
commit 2ed192c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/kuma/authkeys/templates/authkeys/list.html b/kuma/authkeys/templates/authkeys/list.html
@@ -32,9 +32,9 @@
 {% endif %}
 
 {% else %}
-<p>{% trans %}
+<p>{% trans bugzilla_url="https://bugzilla.mozilla.org/enter_bug.cgi?format=__standard__&product=Mozilla Developer Network&component=User management" %}
   You need a special permission to use API keys.
-  You may request permission by <a href="https://bugzilla.mozilla.org/enter_bug.cgi?format=__standard__&product=Mozilla Developer Network&component=User management">filing a bug</a>.
+  You may request permission by <a href="{{ bugzilla_url }}">filing a bug</a>.
 {% endtrans %}
 </p>
 

diff --git a/kuma/authkeys/views.py b/kuma/authkeys/views.py
@@ -11,6 +11,7 @@
 ITEMS_PER_PAGE = 15
 
 
+@login_required
 @permission_required('authkeys.add_key', raise_exception=True)
 def new(request):
     context = {"key": None}
@@ -48,6 +49,7 @@ def history(request, pk):
     return render(request, 'authkeys/history.html', context)
 
 
+@login_required
 @permission_required('authkeys.delete_key', raise_exception=True)
 def delete(request, pk):
     key = get_object_or_404(Key, pk=pk)

diff --git a/kuma/users/helpers.py b/kuma/users/helpers.py
@@ -55,7 +55,7 @@ def admin_link(context, user):
     """Returns a link to admin a user"""
     link = ''
     url = reverse('admin:auth_user_change', args=(user.id,))
-    link = '<a href="%s" class="button neutral">%s<i aria-hidden="true" class="icon-lock"></i></a>' % (url, _('Admin'))
+    link = '<a href="%s" class="button neutral">%s<i aria-hidden="true" class="icon-wrench"></i></a>' % (url, _('Admin'))
     return Markup(link)