Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Commit

Permalink
Merge pull request #141 from lmorchard/bug-731651-improve-template-ed…
Browse files Browse the repository at this point in the history
…iting

Bug 731651 template syntax highlighting and ACE editor
  • Loading branch information
groovecoder committed Mar 26, 2012
2 parents 638dffe + fa9f570 commit 9c0c81c
Show file tree
Hide file tree
Showing 10 changed files with 9,806 additions and 11 deletions.
6 changes: 5 additions & 1 deletion apps/wiki/templates/wiki/document.html
Expand Up @@ -109,7 +109,11 @@ <h2>Table of Contents</h2>
</div>
#}
{% if not fallback_reason %}
{{ document_html|safe }}
{% if document.is_template %}
<pre class="brush: js">{{ document_html }}</pre>
{% else %}
{{ document_html|safe }}
{% endif %}
{% elif fallback_reason == 'no_translation' %}
<div id="doc-pending-fallback" class="warning-box">
{% trans help_link=url('wiki.document', 'localize-firefox-help'),
Expand Down
15 changes: 14 additions & 1 deletion apps/wiki/templates/wiki/edit_document.html
Expand Up @@ -9,7 +9,7 @@
(document.get_absolute_url(), document.title),
(None, _('Edit Article'))] %}
{% set classes = 'edit' %}
{% block bodyclass %}edit{% endblock %}
{% block bodyclass %}edit{% if document.is_template %} is-template{% endif %}{% endblock %}

{% block content %}
<section id="content">
Expand Down Expand Up @@ -120,6 +120,9 @@ <h1>{{ _('Editing <em>{title}</em>')|fe(title=revision.title) }}</h1>

{% if revision_form %}
{{ revision_form.content | safe }}
{% if document.is_template %}
<div id="ace_content"></div>
{% endif %}
<input type="hidden" name="form" value="rev" />
<section>
<h4>{{_('Review needed?')}}</h4>
Expand All @@ -142,4 +145,14 @@ <h4>{{_('Review needed?')}}</h4>
{% block site_js %}
{{ super() }}
{{ js('framebuster') }}

{% if document.is_template %}
<script src="{{ MEDIA_URL }}ace/ace.js"
type="text/javascript" charset="utf-8"></script>
<script src="{{ MEDIA_URL }}ace/theme-dreamweaver.js"
type="text/javascript" charset="utf-8"></script>
<script src="{{ MEDIA_URL }}ace/mode-javascript.js"
type="text/javascript" charset="utf-8"></script>
{% endif %}

{% endblock %}
1 change: 1 addition & 0 deletions apps/wiki/views.py
Expand Up @@ -228,6 +228,7 @@ def set_common_headers(r):
# Grab the document HTML as a fallback, then attempt to use kumascript:
doc_html, ks_errors = doc.html, None
if (constance.config.KUMASCRIPT_TIMEOUT > 0 and
not doc.is_template and
(force_macros or (not no_macros and not show_raw))):
# We'll make a request to kumascript for macro evaluation only if:
# * The service isn't disabled with a timeout of 0
Expand Down
10 changes: 10 additions & 0 deletions media/ace/ace.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions media/ace/mode-javascript.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions media/ace/theme-dreamweaver.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9c0c81c

Please sign in to comment.