Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigating to a page which is configured to redirect elsewhere results in a 404 if the user's browser isn't in English #6966

Open
globau opened this issue Nov 19, 2021 · 3 comments
Labels
accepting PR We invite you to open a PR to resolve this issue. enhancement Improves an existing feature. 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. idle localization i18n & l10n p4 Not urgent, only if time allows redirects all things related to redirecting

Comments

@globau
Copy link

globau commented Nov 19, 2021

Summary
What is the problem?

Navigating to a page which is configured to redirect elsewhere results in a 404 if the user's browser isn't in English.

Steps To Reproduce (STR)
How can we reproduce the problem?

  1. Change your web browser to Spanish
  2. Visit https://developer.mozilla.org/docs/Mozilla/QA/Bug_writing_guidelines

Actual behavior
What actually happened?

Redirected to https://developer.mozilla.org/LN/docs/Mozilla/QA/Bug_writing_guidelines which is a 404

Expected behavior
What did you expect to happen?

Redirected to https://bugzilla.mozilla.org/page.cgi?id=bug-writing.html as per https://github.com/mdn/content/blob/main/files/en-us/_redirects.txt

Additional context
Is there anything else we should know?

Originally filed by CarlosT as https://bugzilla.mozilla.org/show_bug.cgi?id=1740704

@japneetsingh035
Copy link

Hi @globau, I would like to work on this issue. Please let me know if it is up for grab!

@globau
Copy link
Author

globau commented Dec 7, 2021

@japneetsingh035 My involvement here is just to shift the issue into GitHub, so I can't speak for the MDN team.
It appears this issue hasn't even been triaged, so I don't know what its status is.

That said, given the lack of activity it sure appears to be up for grabs!

@caugner caugner transferred this issue from mdn/kuma Aug 26, 2022
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Aug 26, 2022
@github-actions github-actions bot added the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Nov 11, 2022
@caugner
Copy link
Contributor

caugner commented Nov 14, 2022

Here's what happens:

  1. https://developer.mozilla.org/docs/Mozilla/QA/Bug_writing_guidelines redirects to https://developer.mozilla.org/es/docs/Mozilla/QA/Bug_writing_guidelines
  2. Since that page doesn't exist, it requests https://developer.mozilla.org/en-US/docs/Mozilla/QA/Bug_writing_guidelines to see if it exists and gets a 302.

So what we should do is parse that 302 response and show something like:

The page you requested doesn't exist in (language), but the English version redirects here: (url)

@caugner caugner added enhancement Improves an existing feature. localization i18n & l10n p4 Not urgent, only if time allows redirects all things related to redirecting accepting PR We invite you to open a PR to resolve this issue. and removed 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Nov 14, 2022
@github-actions github-actions bot added the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Dec 21, 2022
@github-actions github-actions bot added the idle label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR We invite you to open a PR to resolve this issue. enhancement Improves an existing feature. 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. idle localization i18n & l10n p4 Not urgent, only if time allows redirects all things related to redirecting
Projects
Status: No status
Development

No branches or pull requests

3 participants