Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

fix bug 843068 - When signing up, some users enter their email address i... #1015

Closed
wants to merge 3 commits into from

Conversation

tx2z
Copy link
Contributor

@tx2z tx2z commented Apr 15, 2013

...n the "Username" field

https://bugzilla.mozilla.org/show_bug.cgi?id=843068

Page: https://developer.mozilla.org/en-US/users/browserid_register

  • I've add the placeholder "john_smith" into "Username" input
  • I've add the text: "Please enter the name you'd like to display to other users to identify your contributions." under "Username" input.
  • I've changed the rule to reject the "@" character in the input and I've deleted the "@" in the error message (now it's "Letters, digits and ./-/_ only."

@@ -43,6 +43,7 @@
<li>
<label for="id_username">{{ _('Username') }}</label>
{{ register_form.username|safe }}
<p><small>Please enter the name you'd like to display to other users to identify your contributions.</small></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to wrap all strings with gettext so they can be translated. Either like {{ _('Please enter the name ...') }} or:

{% trans %}
<p><small>Please enter the name ...</small></p>
{% endtrans %}

@tx2z
Copy link
Contributor Author

tx2z commented Apr 15, 2013

Sorry groovecoder, I've messed-up with the vendor thing :S I'm going to close this pull request and send another one because I don't know how to update the submodule in my branch... (I've tried lot of things unsuccessful :S) so I think It's going to be easy create a new branch and pass my changes to it...

@tx2z tx2z closed this Apr 15, 2013
@tx2z tx2z deleted the bugzilla843068 branch April 15, 2013 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants