Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Bug 1209185 - Move locale/ folder from Subversion to Git #3575

Merged
merged 7 commits into from Oct 20, 2015
Merged

Conversation

robhudson
Copy link
Contributor

Before merging we need to let #mathjazz know to coordinate with a change in verbatim and pontoon configuration.

@groovecoder
Copy link
Contributor

OMG 😍 Yay!

@@ -37,3 +36,5 @@ kuma/static/js/libs/ckeditor/source/ckbuilder
.env
*devmo*.sql*
htmlcov/
locale/**/z-*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are those two entries for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were there before so I chose to leave them. I can look into removing them.

@jezdez
Copy link
Contributor

jezdez commented Oct 19, 2015

When I checked out the branch I have lots of *.mo files in the locale dir that git didn't know about. Assuming we don't want to commit the binary mo files into the repo we should add them to the .gitignore as well.

Could you split the adding of the files and the other modifications into separate commits so it's easier to review here?

@jezdez
Copy link
Contributor

jezdez commented Oct 19, 2015

@jezdez
Copy link
Contributor

jezdez commented Oct 19, 2015

rwc+

@jezdez jezdez assigned robhudson and unassigned jezdez Oct 19, 2015
@robhudson
Copy link
Contributor Author

Could you split the adding of the files and the other modifications into separate commits so it's easier to review here?

I thought I did. The addition of the locale files and updating the .pot files are together b/c the .pot files were apparently pretty far out of date and were large but I could separate those?

@jezdez
Copy link
Contributor

jezdez commented Oct 19, 2015

@robhudson Ah, that explains it. Fair enough. r+

robhudson added a commit that referenced this pull request Oct 20, 2015
Bug 1209185 - Move locale/ folder from Subversion to Git
@robhudson robhudson merged commit d0902dc into master Oct 20, 2015
@jwhitlock jwhitlock deleted the locale-git branch October 22, 2015 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants