bug 1431259: do not cache docs if logged-in user or ks errors #4734
Conversation
| assert 'max-age=0' in response['Cache-Control'] | ||
| assert 'no-cache' in response['Cache-Control'] | ||
| assert 'no-store' in response['Cache-Control'] | ||
| assert 'must-revalidate' in response['Cache-Control'] |
There was a problem hiding this comment.
I'm reconsidering if we should have a function like assert_no_cache_header. This repetition seems harmful to understanding.
There was a problem hiding this comment.
I think you're right. I think it's worth introducing both assert_no_cache_header and assert_cache_header and submitting in a new PR.
kuma/wiki/views/document.py
Outdated
| return redirect(redirect_url) | ||
| response = redirect(redirect_url) | ||
| if request.user.is_authenticated(): | ||
| add_never_cache_headers(response) |
There was a problem hiding this comment.
Does the fallback_doc vary for logged-in users? If not, I don't see why we shouldn't cache the redirect.
There was a problem hiding this comment.
My original intention was simply to be thorough in not caching when the user is logged-in, but you're right, I don't think this can vary for logged-in users. I will remove it.
|
Thanks for the review @jwhitlock! I removed the code that added the never cache header to the default-locale fallback response, and then re-based and force pushed. |
|
👍 I'm OK to merge, if you want to save the test utility functions for a new PR. |
This PR adjusts the
Cache-Controlheader for documents. We will no longer cache if the user is logged-in or there are Kumascript errors. This should help with issues due to caching when a user deletes, restores, or re-renders a document.