Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looker explores for glean pings shouldn't have client count measure if ping doesn't have a client count #253

Open
wlach opened this issue Oct 1, 2021 · 1 comment
Labels
Glean Changes for Glean Pings and automated Glean derived tables

Comments

@wlach
Copy link
Contributor

wlach commented Oct 1, 2021

A good example would be the explore for the background update ping: https://mozilla.cloud.looker.com/explore/firefox_desktop_background_update/background_update?qid=XMTEmtkFtlBVT9sCPQ9pSh&toggle=fil,vis

The client count has no meaning, because a client id is not sent with these pings:

https://dictionary.telemetry.mozilla.org/apps/firefox_desktop_background_update/pings/background-update

We should hide this measure for this case.

@wlach
Copy link
Contributor Author

wlach commented Nov 18, 2021

We should hide this measure for this case.

Prior art for hiding a measure: #233

Although now that I think about it, a better solution would be to not generate the measure at all, rather than hiding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Glean Changes for Glean Pings and automated Glean derived tables
Projects
None yet
Development

No branches or pull requests

1 participant