Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to looker explores should not reference client count for pings without a client id #873

Closed
wlach opened this issue Oct 1, 2021 · 0 comments
Assignees
Labels

Comments

@wlach
Copy link
Contributor

wlach commented Oct 1, 2021

A good example would be the explore for the background update ping: https://mozilla.cloud.looker.com/explore/firefox_desktop_background_update/background_update?qid=XMTEmtkFtlBVT9sCPQ9pSh&toggle=fil,vis

The client count has no meaning, because a client id is not sent with these pings:

https://dictionary.telemetry.mozilla.org/apps/firefox_desktop_background_update/pings/background-update

For these cases, we should specify the ping count measure instead of client count. The offending line is here:

f"{ping_name_snakecase}.clients",

However, you will need to find out if the ping that a metric is a part of includes a client identifier for each case (note that metrics might be sent by more than one ping, some of which may have a client identifier and some of which may not).

@Iinh can you take this one when you have time? This is more of an edge case than #871 but we should still fix it.

See also: mozilla/lookml-generator#253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants