This repository has been archived by the owner on Dec 1, 2017. It is now read-only.
Bug 1273501 - create thumbnail from screenshot of current state of a url. r=fcampo #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autolander could not find a bug number in your pull request title. All pull requests should be in the format of: Bug [number] - [description]. |
|
(Or, if noone grabs it, we'll find someone US time to dig into tomorrow)... |
|
@Standard8 @fcampo Who can do the review? |
| @@ -160,11 +160,10 @@ loop.shared.actions = (function() { | |||
| /** | |||
| * Used to add a page to the current room | |||
| */ | |||
| // XXX akita: Update actions when metadata extraction bug is landed | |||
There was a problem hiding this comment.
please refer to bug number for better tracking
mancas
force-pushed
the
bug-1273501-create-thumbnail-from-screenshot-of-current-state-of-a-url
branch
from
b910ec6
to
a2f9c1d
Compare
mancas
changed the title
mancas
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #494 isn't writable, I forked it. And, it should be writable by everyone on the team, I think/hope, so this PR will supercede that one.
After the first of these commits, things worked nicely.
Then I rebased against the latest akita, added the second commit, and now it's broken because the metadata fields in getPageMetadata no longer match the ones that the action and the pageStore expect. That should be easy to fix up, though.
After that, I think this wants a bit of basic cleanup along with some XXXakita love, as well as possible test tweaks, and we'll have the functionality working for URLs added by the + button.
I've started work based on top of the not-yet-rebased version of this patch over in bug 1274416 to make the initial URL get the metadata used properly as well.
CC @mancas, @crafuse, @fernando, @Standard8, @ianb
I think anyone in the european timezone who wants to take this bug and run with it should feel free.