Bug 1236590 - create a loop-dev profile when no existing profile is specified and found #59
Conversation
mikedeboer
force-pushed
the
bug-1236590-userPrefs
branch
from
d68e566
to
e33f7f4
Compare
| function createEmptyProfile(profile) { | ||
| return When.promise(function(resolve, reject) { | ||
| var profileDir = randomString() + "." + profile; | ||
| var finder = new FxProfileFinder(); |
There was a problem hiding this comment.
Could we make use of the -CreateProfile command line argument instead of reimplementing some of the profile creation logic? Something like.. require("child_process").spawn('/Applications/Firefox.app/Contents/MacOS/firefox-bin', ["-CreateProfile", "loop-dev"])
There was a problem hiding this comment.
Sure, I didn't know about that one + didn't know that it shut down the process right after it created the profile. nice!
mikedeboer
force-pushed
the
bug-1236590-userPrefs
branch
from
e33f7f4
to
3d3c5d0
Compare
|
@Mardak I'm now using |
…e found or isn't specified. Also make sure that the right prefs have been set to aid in Hello developement. r=Mardak
mikedeboer
force-pushed
the
bug-1236590-userPrefs
branch
from
3d3c5d0
to
2735e2a
Compare
| return value; | ||
| } | ||
|
|
||
| function takePrefsSample(profilePath) { |
There was a problem hiding this comment.
What do you mean by Sample? This looks to read in the whole prefs file as opposed to some of it. There's various things that make this function somewhat hard to read, and we might not actually need all the complexity anyway. See comment for setUserPrefs.
|
Also would be good to update |
Its Also, if Thanks. |
|
Support for Hello/Loop has been discontinued. https://support.mozilla.org/kb/hello-status Hence closing the old bugs. Thank you for your support. |
Create a new 'loop-dev' browser profile when none can be found or isn't specified. Also make sure that the right prefs have been set to aid in Hello developement