Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Explain diff between makerstrap.complete.min.css and makerstrap.min.css more clearly in docs #13

Merged
merged 1 commit into from Jul 9, 2014

Conversation

mlveis
Copy link
Contributor

@mlveis mlveis commented Apr 16, 2014

This is kind of confusing as is.

@k88hudson k88hudson added this to the 0.1.0 milestone Feb 10, 2014
@k88hudson k88hudson removed this from the 0.1.0 milestone Feb 18, 2014
@k88hudson k88hudson added this to the 0.2.0 milestone Mar 5, 2014
@mlveis mlveis self-assigned this Apr 8, 2014
mlveis added a commit to mlveis/makerstrap that referenced this pull request Apr 16, 2014
@mlveis mlveis assigned k88hudson and unassigned mlveis Apr 16, 2014
@k88hudson k88hudson assigned gvn and unassigned k88hudson Apr 21, 2014
@k88hudson
Copy link
Contributor

Assigning to gvn for review since he filed it

<tr>
<td>makerstrap.complete.min.css</td>
<td>Minified CSS <br />
should not be used in production <br />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is actually our recommendation. @k88hudson ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, using complete @imports font awesome and open sans stylesheets and is not recommended for production since @import blocks concurrent downloads

@gvn
Copy link
Contributor Author

gvn commented May 5, 2014

I'd add this clarification to the README as well, but after that and the tweak I noted: R+.

mlveis added a commit to mlveis/makerstrap that referenced this pull request May 29, 2014
@k88hudson
Copy link
Contributor

Hey, what's happening with this? Can we rebase/merge?

@k88hudson k88hudson removed this from the 0.2.0 milestone Jul 7, 2014
@mlveis
Copy link
Contributor

mlveis commented Jul 8, 2014

@k88hudson I have rebased this. Just let me know if its ok and then I can merge it.

k88hudson added a commit that referenced this pull request Jul 9, 2014
Explain diff between makerstrap.complete.min.css and makerstrap.min.css more clearly in docs
@k88hudson k88hudson merged commit 9cb7341 into mozilla:master Jul 9, 2014
@k88hudson k88hudson assigned mlveis and unassigned gvn Jul 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants