Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

Removed _navigate_to_first_free_app and placed explicit steps in each test case #44

Merged
merged 4 commits into from
Jun 20, 2012
Merged

Removed _navigate_to_first_free_app and placed explicit steps in each test case #44

merged 4 commits into from
Jun 20, 2012

Conversation

bobsilverberg
Copy link
Contributor

No description provided.

@klrmn
Copy link
Contributor

klrmn commented Jun 19, 2012

uh, why?

@bobsilverberg
Copy link
Contributor Author

There is a thread on the mozwebqa@mozilla.org mailing list in which Zac requested that it be removed.

@klrmn
Copy link
Contributor

klrmn commented Jun 19, 2012

i do not think it is in any way the result of this change, but TestDeveloperHub.test_that_checks_apps_are_sorted_by_name is failing for me.
i think it might be a good idea for the application names to have a little bit more variety than the timestamp.
and since when is 'bob' not before 'Mock'?

E AssertionError: Mock Application 1338425458 is not before bob. Apps are not sorted ascending.
E App names = [u'bob', u'Mock Application 1338425458', u'Mock Application 1338425820', u'Mock Application 1338425986', u'Mock Application 1338426339', u'Mock Application 1338426821', u'Mock Application 1338427909', u'Mock Application 1338428082', u'Mock Application 1338429814', u'Mock Application 1338431501']

@bobsilverberg
Copy link
Contributor Author

I just noticed the exact same thing. I don't know how that app's name got updated to bob, but I assume it had something to do with me. It does seem that that change is causing the test to now fail, which is an indicator that perhaps there is something wrong with the test.

@AlinT
Copy link
Contributor

AlinT commented Jun 20, 2012

Please fix the merge conflicts.

Conflicts:
	tests/desktop/test_developer_hub.py
@AlinT
Copy link
Contributor

AlinT commented Jun 20, 2012

The is another test in test_developer_hub.py that need the _navigate_to_first_free_app() method removed:
test_that_checks_editing_support_information_for_a_free_app()

@AlinT
Copy link
Contributor

AlinT commented Jun 20, 2012

Looks good to me & merging!

AlinT added a commit that referenced this pull request Jun 20, 2012
Removed _navigate_to_first_free_app and placed explicit steps in each test case
@AlinT AlinT merged commit b44c305 into mozilla:master Jun 20, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants