This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Bug 1226382: Store Firefox OS strings in separate pofiles. #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db_strings.py now generates pot files for each Firefox OS version in the
database, and then uses msgmerge to merge them into individual pofiles
for each locale. makemessages is replaced by extract and merge from
puente, which extracts non-database strings to messages.po instead of
django.po.
A new script, collectstrings.py, is added to collect the strings from
all the pofiles for a locale and combine them together into a django.po
file that can be used for translation.
This is missing some tests for the utilities, possibly some tests for the commands themselves (@jgmize said they'd be a nice-to-have), better comments/docstrings, and updates to the sphinx documentation about the l10n flow. I'll be working on those next along with testing this on the demo instance that was set up.
But since I'm off for the holiday starting tomorrow and not sure if I'll get all that done by the end of today, I'm submitting this now for preliminary review and commentary. I tested locally and, as far as I can tell, this is working pretty well. The django.po files generated by the new flow have all the same entities as the old ones.
@glogiotatidis Any preliminary input/review on this would be appreciated, otherwise I'll ping you again when the remaining tasks I mentioned above are done. Thanks!