This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Update homepage promo tests to check valid link responses only #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgmize r? |
alexgibson
changed the title
|
Thx, @alexgibson - I've asked @bobsilverberg to r? too |
|
LGTM and the tests pass on all three environments for me. r+ and merging |
bobsilverberg
added a commit
that referenced
this pull request
Jan 20, 2015
Update homepage promo tests to check valid link responses only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating home page promo tests to only check for valid link responses, as opposed to also each promo
href.Because homepage promo's change quite often, these tests are probably a bit overly specific and require more maintenance than they should. We are also now using waffle on the home page to toggle different promo's, so checking each
hrefspecifically might not be appropriate any more.