Add dynamic dimensions to comparison view graph, change x-axis scale #53
Conversation
|
@ecomerford I have not seen that, could you try to reproduce the issue with a minimal example on codepen (you can use this as a template: https://codepen.io/wlach/pen/LBvwLw) and file an issue with metrics graphics? It's probably just a bug. |
| handleChange = (event) => { | ||
| this.setState({compareVersion: event}); | ||
| } | ||
|
|
||
| componentDidMount() { | ||
| window.addEventListener("resize", this.onResize); | ||
| this.onResize(); |
There was a problem hiding this comment.
With missioncontrol I used react-dimensions to scale the graphs automatically. I think it's a little more elegant and less bespoke:
There was a problem hiding this comment.
Interesting, thanks! Reading up on this.
There was a problem hiding this comment.
I believe this runs into the same problem with the non-shown-but-still-rendered tabs where the containers have 0 height and width until shown, but I would be pleased to be shown to be wrong.
|
@wlach hm, I'm not able to reproduce it in that codepen example by switching the |
| handleChange = (event) => { | ||
| this.setState({compareVersion: event}); | ||
| } | ||
|
|
||
| componentDidMount() { | ||
| window.addEventListener("resize", this.onResize); | ||
| this.onResize(); |
There was a problem hiding this comment.
I believe this runs into the same problem with the non-shown-but-still-rendered tabs where the containers have 0 height and width until shown, but I would be pleased to be shown to be wrong.
| @@ -73,6 +86,8 @@ export class ComparisonView extends Component { | |||
| y_accessor="proportion" | |||
| x_accessor="start" | |||
| area={[true, true]} | |||
| x_scale_type= "log" | |||
There was a problem hiding this comment.
Seems like some unintentional whitespace after = on this and the following line?
|
@ecomerford hmm, probably something about the shape of the data here then -- are you seeing any error in the console? If all else fails, if you give me instructions on how to check this out and test I could try to reproduce locally. |
This PR addresses issues #43 and #29. I've added a window resize handler like the one @chutten made for the distribution view, so that now all three graphs respond to the window size and are much more readable.
I also changed the
x_scale_typeof the metrics-graphics graph tolog, which seems to have fixed the shape of the graph, but for some reason made the lines disappear (you can still see each point when hovering). @wlach have you seen this happen before?This PR may need a few more adjustments once I've looked into the
logtype and why it disappears the graph lines.